Put persistent pref storage into StateModel. Turned on App Sandbox.

RedditBar.xcodeproj/project.pbxproj

@@ -74,6 +74,7 @@
 		E9CF1F4A184961020004AE02 /* RedditBarTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RedditBarTests.m; sourceTree = "<group>"; };
 		E9CF1F5A1849685C0004AE02 /* PrefController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PrefController.h; sourceTree = "<group>"; };
 		E9CF1F5B1849685C0004AE02 /* PrefController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = PrefController.m; sourceTree = "<group>"; };
+		E9F64A2B185D51C100D6CA16 /* RedditBar.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = RedditBar.entitlements; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -139,6 +140,7 @@
 		E9CF1F26184961010004AE02 /* RedditBar */ = {
 			isa = PBXGroup;
 			children = (
+				E9F64A2B185D51C100D6CA16 /* RedditBar.entitlements */,
 				E9CF1F32184961010004AE02 /* AppDelegate.h */,
 				E9CF1F33184961010004AE02 /* AppDelegate.m */,
 				E9B6773C184B73DC00850559 /* Reddit.h */,
@@ -237,6 +239,13 @@
 				LastUpgradeCheck = 0500;
 				ORGANIZATIONNAME = xythobuz;
 				TargetAttributes = {
+					E9CF1F1C184961010004AE02 = {
+						SystemCapabilities = {
+							com.apple.Sandbox = {
+								enabled = 1;
+							};
+						};
+					};
 					E9CF1F3D184961020004AE02 = {
 						TestTargetID = E9CF1F1C184961010004AE02;
 					};
@@ -479,6 +488,8 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				CODE_SIGN_ENTITLEMENTS = RedditBar/RedditBar.entitlements;
+				CODE_SIGN_IDENTITY = "-";
 				COMBINE_HIDPI_IMAGES = YES;
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "RedditBar/RedditBar-Prefix.pch";
@@ -493,6 +504,8 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				CODE_SIGN_ENTITLEMENTS = RedditBar/RedditBar.entitlements;
+				CODE_SIGN_IDENTITY = "-";
 				COMBINE_HIDPI_IMAGES = YES;
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "RedditBar/RedditBar-Prefix.pch";

RedditBar/AppDelegate.m

@@ -43,44 +43,12 @@
     [statusItem setToolTip:NSLocalizedString(@"RedditBar", @"Main Menuitem Tooltip")];
     [statusItem setHighlightMode:YES];
     currentState = [[StateModel alloc] init];
-    [self defaultPreferences];
-    [self loadPreferences];
+    [currentState registerDefaultPreferences];
+    [currentState loadPreferences];
     lastFullName = nil;
     [self reloadListWithOptions];
 }
 
--(void)defaultPreferences {
-    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
-    NSMutableDictionary *appDefaults = [NSMutableDictionary dictionaryWithObject:@"" forKey:@"username"];
-    [appDefaults setValue:@"" forKey:@"modhash"];
-    [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:@"subscriptions"];
-    [appDefaults setValue:[NSNumber numberWithInt:10] forKey:@"length"];
-    [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:@"showSubs"];
-    [store registerDefaults:appDefaults];
-}
-
--(void)savePreferences {
-    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
-    [store setObject:currentState.username forKey:@"username"];
-    [store setObject:currentState.modhash forKey:@"modhash"];
-    [store setBool:currentState.useSubscriptions forKey:@"subscriptions"];
-    [store setObject:currentState.subreddits forKey:@"subreddits"];
-    [store setInteger:currentState.length forKey:@"length"];
-    [store setBool:currentState.showSubreddit forKey:@"showSubs"];
-    [store synchronize];
-}
-
--(void)loadPreferences {
-    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
-    [store synchronize];
-    [currentState setUsername:[store stringForKey:@"username"]];
-    [currentState setModhash:[store stringForKey:@"modhash"]];
-    [currentState setUseSubscriptions:[store boolForKey:@"subscriptions"]];
-    [currentState setSubreddits:[store arrayForKey:@"subreddits"]];
-    [currentState setLength:[store integerForKey:@"length"]];
-    [currentState setShowSubreddit:[store boolForKey:@"showSubs"]];
-}
-
 -(void)reloadListNotAuthenticatedCallback {
     [firstMenuItem setTitle:NSLocalizedString(@"Login Error!", @"Statusitem when API is not authenticated")];
     [self clearMenuItems];
@@ -238,7 +206,7 @@
     currentState.subreddits = [subreddits componentsSeparatedByString: @"\n"];
     currentState.length = length;
     currentState.showSubreddit = showSubreddits;
-    [self savePreferences];
+    [currentState savePreferences];
     lastFullName = nil; // reload from start
     [self reloadListWithOptions];
 }

RedditBar/Reddit.m

@@ -194,17 +194,19 @@ NSString *subredditFormat = @" [r/%@]";
 
 -(void)isAuthenticatedNewModhash:(id)parent {
     NSHTTPURLResponse *response;
-    NSData *data = [self queryAPI:@"api/me.json" withResponse:&response];
-    if ((data != nil) && ([response statusCode] == 200)) {
+    NSData *dat = [self queryAPI:@"api/me.json" withResponse:&response];
+    if ((dat != nil) && ([response statusCode] == 200)) {
         NSError *error;
-        NSDictionary *json = [NSJSONSerialization JSONObjectWithData:data options:0 error:&error];
+        NSDictionary *json = [NSJSONSerialization JSONObjectWithData:dat options:0 error:&error];
         NSDictionary *data = [json valueForKey:@"data"];
         if (data == nil) {
+            NSLog(@"Not logged in!");
             [parent performSelectorOnMainThread:@selector(reloadListNotAuthenticatedCallback) withObject:nil waitUntilDone:false];
             return;
         }
         NSString *newHash = [data valueForKey:@"modhash"];
         if ((newHash == nil) || ([newHash isEqualToString:@""])) {
+            NSLog(@"Did not receive modhash!");
             [parent performSelectorOnMainThread:@selector(reloadListNotAuthenticatedCallback) withObject:nil waitUntilDone:false];
             return;
         }
@@ -231,8 +233,7 @@ NSString *subredditFormat = @" [r/%@]";
     NSData *data = [NSURLConnection sendSynchronousRequest:request returningResponse:res error:&error];
     if (error)
         return nil;
-    else
-        return data;
+    return data;
 }
 
 -(NSData *)queryAPI:(NSString *)api withData:(NSString *)string andResponse:(NSHTTPURLResponse **)res {
@@ -246,14 +247,14 @@ NSString *subredditFormat = @" [r/%@]";
     [request setValue:[NSString stringWithFormat:@"%@/%@ by %@", appName, version, author] forHTTPHeaderField:@"User-Agent"];
     if ((modhash != nil) && (![modhash isEqualToString:@""]))
         [request addValue:modhash forHTTPHeaderField:@"X-Modhash"];
+    
     [request setHTTPMethod:@"POST"];
     [request setHTTPBody:requestBodyData];
     NSError *error = nil;
     NSData *data = [NSURLConnection sendSynchronousRequest:request returningResponse:res error:&error];
     if (error)
         return nil;
-    else
-        return data;
+    return data;
 }
 
 -(NSURL *)getAPIPoint:(NSString *)where {

RedditBar/RedditBar-Info.plist

@@ -21,7 +21,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>187</string>
+	<string>204</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>

RedditBar/RedditBar.entitlements

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>com.apple.security.app-sandbox</key>
+	<true/>
+	<key>com.apple.security.network.client</key>
+	<true/>
+</dict>
+</plist>

RedditBar/StateModel.h

@@ -37,4 +37,8 @@
 @property (atomic) NSInteger length;
 @property (atomic) Boolean showSubreddit;
 
+-(void)registerDefaultPreferences;
+-(void)savePreferences;
+-(void)loadPreferences;
+
 @end

RedditBar/StateModel.m

@@ -30,6 +30,39 @@
 
 @implementation StateModel
 
-@synthesize username, modhash, useSubscriptions, subreddits, showSubreddit;
+@synthesize username, modhash, useSubscriptions, subreddits, length, showSubreddit;
+
+-(void)registerDefaultPreferences {
+    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
+    NSMutableDictionary *appDefaults = [NSMutableDictionary dictionaryWithObject:@"" forKey:@"username"];
+    [appDefaults setValue:@"" forKey:@"modhash"];
+    [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:@"subscriptions"];
+    [appDefaults setValue:[NSNumber numberWithInt:10] forKey:@"length"];
+    [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:@"showSubs"];
+    [appDefaults setValue:@"" forKey:@"session"];
+    [store registerDefaults:appDefaults];
+}
+
+-(void)savePreferences {
+    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
+    [store setObject:username forKey:@"username"];
+    [store setObject:modhash forKey:@"modhash"];
+    [store setBool:useSubscriptions forKey:@"subscriptions"];
+    [store setObject:subreddits forKey:@"subreddits"];
+    [store setInteger:length forKey:@"length"];
+    [store setBool:showSubreddit forKey:@"showSubs"];
+    [store synchronize];
+}
+
+-(void)loadPreferences {
+    NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
+    [store synchronize];
+    username = [store stringForKey:@"username"];
+    modhash = [store stringForKey:@"modhash"];
+    useSubscriptions = [store boolForKey:@"subscriptions"];
+    subreddits = [store arrayForKey:@"subreddits"];
+    length = [store integerForKey:@"length"];
+    showSubreddit = [store boolForKey:@"showSubs"];
+}
 
 @end

RedditBar/de.lproj/Localizable.strings

@@ -17,7 +17,7 @@
 "Loading..." = "Lade...";
 
 /* Statusitem when API is not authenticated */
-"Login Error!" = "Fehler beim login!";
+"Login Error!" = "Fehler beim Login!";
 
 /* Statusitem when no modhash is stored */
 "Not logged in!" = "Nicht eingeloggt!";