Implemented Unread PM Notifications.

RedditBar/AppDelegate.h

@@ -31,7 +31,7 @@
 #import "StateModel.h"
 #import "Reddit.h"
 
-@interface AppDelegate : NSObject <NSApplicationDelegate>
+@interface AppDelegate : NSObject <NSApplicationDelegate, NSUserNotificationCenterDelegate>
 
 @property (atomic, retain) IBOutlet NSMenu *statusMenu;
 @property (atomic, retain) IBOutlet NSApplication *application;
@@ -64,7 +64,7 @@
 -(void)reloadListNotAuthenticatedCallback;
 -(void)reloadListHasSubredditsCallback:(NSArray *)items;
 -(void)reloadListHasFrontpageCallback:(NSArray *)items;
--(void)readPMsCallback:(NSNumber *)items;
+-(void)readPMsCallback:(NSArray *)items;
 -(void)singleItemReloadedCallback:(NSArray *)items;
 
 -(void)prefsDidSave;

RedditBar/AppDelegate.m

@@ -32,8 +32,9 @@
 
 NSInteger itemsBeforeLinkList = 2;
 NSInteger numberOfStaticMenuItems = 10;
+
 #define MULTIPLIER_PM_INTERVALL_TO_SEC 60
-#define RECHECK_PM_AFTER_OPEN 10
+#define RECHECK_PM_AFTER_OPEN 7
 #define SUBMENU_INDEX_LINK 0
 #define SUBMENU_INDEX_COMMENTS 1
 #define SUBMENU_INDEX_BOTH 2
@@ -58,6 +59,15 @@ NSInteger numberOfStaticMenuItems = 10;
     lastFullName = nil;
     [self reloadListWithOptions];
     [self recreateRefreshTimer];
+    [[NSUserNotificationCenter defaultUserNotificationCenter] setDelegate:self];
+}
+
+-(BOOL)userNotificationCenter:(NSUserNotificationCenter *)center shouldPresentNotification:(NSUserNotification *)notification {
+    return YES;
+}
+
+-(void)userNotificationCenter:(NSUserNotificationCenter *)center didActivateNotification:(NSUserNotification *)notification {
+    [self openUnread:nil];
 }
 
 -(void)recreateRefreshTimer {
@@ -71,8 +81,8 @@ NSInteger numberOfStaticMenuItems = 10;
     [NSThread detachNewThreadSelector:@selector(readPMs:) toTarget:api withObject:self];
 }
 
--(void)readPMsCallback:(NSNumber *)items {
-    if ((items == nil) || ([items integerValue] == 0)) {
+-(void)readPMsCallback:(NSArray *)items {
+    if ((items == nil) || ([items count] < 1) || (((NSNumber *)[items objectAtIndex:0]).integerValue == 0)) {
         [statusItem setImage:statusImage];
         [statusItem setAlternateImage:statusHighlightImage];
         [PMItem setHidden:TRUE];
@@ -80,9 +90,20 @@ NSInteger numberOfStaticMenuItems = 10;
     } else {
         [statusItem setImage:orangeredImage];
         [statusItem setAlternateImage:orangeredHighlightImage];
-        [PMItem setTitle:[NSString stringWithFormat:NSLocalizedString(@"You've got %ld unread PMs!", @"PM message"), (long)items.integerValue]];
+        [PMItem setTitle:[NSString stringWithFormat:NSLocalizedString(@"You've got %ld unread PMs.", @"PM message"), (long)((NSNumber *)[items objectAtIndex:0]).integerValue]];
         [PMItem setHidden:FALSE];
         [PMSeparator setHidden:FALSE];
+
+        if ([items count] >= 2) {
+            if (![currentState.lastNotifiedPM isEqualToString:[items objectAtIndex:1]]) {
+                currentState.lastNotifiedPM = [items objectAtIndex:1];
+                [currentState savePreferences];
+                NSUserNotification *notification = [[NSUserNotification alloc] init];
+                notification.title = NSLocalizedString(@"New Reddit PM!", @"Notification Title");
+                notification.informativeText = [NSString stringWithFormat:NSLocalizedString(@"You've got %ld unread PMs.", nil), (long)((NSNumber *)[items objectAtIndex:0]).integerValue];
+                [[NSUserNotificationCenter defaultUserNotificationCenter] deliverNotification:notification];
+            }
+        }
     }
 }
 

RedditBar/Reddit.m

@@ -228,7 +228,7 @@ NSString *subredditFormat = @" [r/%@]";
     return array;
 }
 
--(NSNumber *)messagesCount:(NSData *)data {
+-(NSArray *)messagesData:(NSData *)data {
     NSError *error;
     NSDictionary *json = [NSJSONSerialization JSONObjectWithData:data options:0 error:&error];
     NSDictionary *dat = [json valueForKey:@"data"];
@@ -237,7 +237,13 @@ NSString *subredditFormat = @" [r/%@]";
     NSArray *children = [dat valueForKey:@"children"];
     if (children == nil)
         return nil;
-    return [NSNumber numberWithInteger:[children count]];
+    NSString *newest_name = nil;
+    if (children.count > 0) {
+        NSDictionary *child = [children objectAtIndex:0];
+        NSDictionary *current = [child valueForKey:@"data"];
+        newest_name = [current valueForKey:@"name"];
+    }
+    return [NSArray arrayWithObjects:[NSNumber numberWithInteger:[children count]], newest_name, nil];
 }
 
 -(void)readPMs:(id)parent {
@@ -247,7 +253,7 @@ NSString *subredditFormat = @" [r/%@]";
     if ((data == nil) || ([response statusCode] != 200)) {
         [(AppDelegate *)parent performSelectorOnMainThread:@selector(readPMsCallback:) withObject:nil waitUntilDone:FALSE];
     } else {
-        [(AppDelegate *)parent performSelectorOnMainThread:@selector(readPMsCallback:) withObject:[self messagesCount:data] waitUntilDone:FALSE];
+        [(AppDelegate *)parent performSelectorOnMainThread:@selector(readPMsCallback:) withObject:[self messagesData:data] waitUntilDone:FALSE];
     }
 }
 

RedditBar/RedditBar-Info.plist

@@ -17,11 +17,11 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.3.1</string>
+	<string>1.4.0</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>301</string>
+	<string>312</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>

RedditBar/StateModel.h

@@ -41,6 +41,7 @@
 @property (atomic, retain) NSString *filter;
 @property (atomic) Boolean removeVisited;
 @property (atomic) Boolean reloadAfterVisit;
+@property (atomic, retain) NSString *lastNotifiedPM;
 
 -(void)registerDefaultPreferences;
 -(void)savePreferences;

RedditBar/StateModel.m

@@ -30,7 +30,7 @@
 
 @implementation StateModel
 
-@synthesize username, modhash, useSubscriptions, subreddits, length, showSubreddit, titleLength, refreshInterval, filter, removeVisited, reloadAfterVisit;
+@synthesize username, modhash, useSubscriptions, subreddits, length, showSubreddit, titleLength, refreshInterval, filter, removeVisited, reloadAfterVisit, lastNotifiedPM;
 
 NSString *s_username = @"username";
 NSString *s_modhash = @"modhash";
@@ -43,6 +43,7 @@ NSString *s_refresh = @"refreshInterval";
 NSString *s_filter = @"filter";
 NSString *s_remove = @"remove";
 NSString *s_reload = @"reload";
+NSString *s_lastPM = @"lastNotifiedPM";
 
 -(void)registerDefaultPreferences {
     NSUserDefaults *store = [NSUserDefaults standardUserDefaults];
@@ -56,6 +57,7 @@ NSString *s_reload = @"reload";
     [appDefaults setValue:@"hot" forKey:s_filter];
     [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:s_remove];
     [appDefaults setValue:[NSNumber numberWithBool:YES] forKey:s_reload];
+    [appDefaults setValue:@"" forKey:s_lastPM];
     [store registerDefaults:appDefaults];
 }
 
@@ -72,6 +74,7 @@ NSString *s_reload = @"reload";
     [store setObject:filter forKey:s_filter];
     [store setBool:removeVisited forKey:s_remove];
     [store setBool:reloadAfterVisit forKey:s_reload];
+    [store setObject:lastNotifiedPM forKey:s_lastPM];
     [store synchronize];
 }
 
@@ -89,6 +92,7 @@ NSString *s_reload = @"reload";
     filter = [store stringForKey:s_filter];
     removeVisited = [store boolForKey:s_remove];
     reloadAfterVisit = [store boolForKey:s_reload];
+    lastNotifiedPM = [store stringForKey:s_lastPM];
 }
 
 @end

RedditBar/de.lproj/Localizable.strings

@@ -22,6 +22,9 @@
 /* Statusitem when API is not authenticated */
 "Login Error!" = "Fehler beim Login!";
 
+/* Notification Title */
+"New Reddit PM!" = "Neue Reddit PM!";
+
 /* Statusitem when no modhash is stored */
 "Not logged in!" = "Nicht eingeloggt!";