Only reload list after saving if necessary.

BaconBarHelper/BaconBarHelper-Info.plist

@@ -21,7 +21,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>29</string>
+	<string>31</string>
 	<key>LSBackgroundOnly</key>
 	<true/>
 	<key>LSMinimumSystemVersion</key>

RedditBar/AppDelegate.h

@@ -67,6 +67,6 @@
 -(void)readPMsCallback:(NSArray *)items;
 -(void)singleItemReloadedCallback:(NSArray *)items;
 
--(void)prefsDidSave;
+-(void)prefsDidSaveReload:(Boolean)shouldReload;
 
 @end

RedditBar/AppDelegate.m

@@ -319,14 +319,16 @@ NSInteger numberOfStaticMenuItems = 10;
     [application orderFrontStandardAboutPanel:self];
 }
 
--(void)prefsDidSave {
+-(void)prefsDidSaveReload:(Boolean)shouldReload {
     [currentState savePreferences];
-    [firstMenuItem setTitle:NSLocalizedString(@"Loading...", nil)];
-    [self clearMenuItems];
-    [firstMenuItem setHidden:NO];
-    lastFullName = nil; // reload from start
-    [self reloadListWithOptions];
     [self recreateRefreshTimer];
+    if (shouldReload) {
+        [firstMenuItem setTitle:NSLocalizedString(@"Loading...", nil)];
+        [self clearMenuItems];
+        [firstMenuItem setHidden:NO];
+        lastFullName = nil; // reload from start
+        [self reloadListWithOptions];
+    }
 }
 
 @end

RedditBar/BaconBar-Info.plist

@@ -21,7 +21,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>385</string>
+	<string>387</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>

RedditBar/PrefController.m

@@ -164,10 +164,30 @@ NSString *subredditCharacters = @"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRST
     else
         start = FALSE;
     
+    NSArray *subredditsToUse = [subreddits.textStorage.string componentsSeparatedByString: @"\n"];
+    
+    Boolean changesRequireReload = FALSE;
+    if (![[username stringValue] isEqualToString:state.username])
+        changesRequireReload = TRUE;
+    if (![modhash isEqualToString:state.modhash])
+        changesRequireReload = TRUE;
+    if (subs != state.useSubscriptions)
+        changesRequireReload = TRUE;
+    if (subs && (![state.subreddits isEqualToArray:subredditsToUse]))
+        changesRequireReload = TRUE;
+    if ([lengthField integerValue] != state.length)
+        changesRequireReload = TRUE;
+    if (print != state.showSubreddit)
+        changesRequireReload = TRUE;
+    if ([titleField integerValue] != state.titleLength)
+        changesRequireReload = TRUE;
+    if (![[filterSelection titleOfSelectedItem] isEqualToString:state.filter])
+        changesRequireReload = TRUE;
+    
     state.username = username.stringValue;
     state.modhash = modhash;
     state.useSubscriptions = subs;
-    state.subreddits = [subreddits.textStorage.string componentsSeparatedByString: @"\n"];
+    state.subreddits = subredditsToUse;
     state.length = [lengthField integerValue];
     state.showSubreddit = print;
     state.titleLength = [titleField integerValue];
@@ -176,7 +196,7 @@ NSString *subredditCharacters = @"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRST
     state.removeVisited = remove;
     state.reloadAfterVisit = reload;
     state.startOnLogin = start;
-    [(AppDelegate *)parent prefsDidSave];
+    [(AppDelegate *)parent prefsDidSaveReload:changesRequireReload];
     [win performClose:self];
 }
 

web/index.html

@@ -70,6 +70,7 @@
                 <div class="panel-body">
                     <ul>
                         <li>Can open BaconBar on login</li>
+                        <li>When saving new Preferences, the list is only reloaded if needed</li>
                     </ul>
                 </div>
             </div>