Consistent use of rc_get_bool.

Also removed some more unused code.

README.md

@@ -128,7 +128,7 @@ If you want to change this behaviour, this happens around line 1075 of `src/Open
 
 ### Console/Config Commands
 
-Console commands (BOOL is now '0' or '1' for less typing).
+Console commands (BOOL is '0', '1', "true" or "false").
 Pressing <UP> will go back to last command entered (saves typing).
 
 #### Game
@@ -183,12 +183,16 @@ Pressing <UP> will go back to last command entered (saves typing).
 
 #### Set Commands
 
+These commands have to be entered as `set COMMAND VALUE` or `set COMMAND=VALUE`.
+
 | Command        | Action                    |
 | --------------:|:------------------------- |
 | mousegrab BOOL | Set mouse grabbing on/off |
 
 #### Stat Commands
 
+These commands have to be entered as `stat COMMAND`.
+
 | Command | Action                 |
 | -------:|:---------------------- |
 | fps     | Toggle showing FPS     |

include/System.h

@@ -68,13 +68,6 @@ public:
     virtual ~System();
 
     /*!
-     * \brief Created a directory
-     * \param path Directory to create
-     * \returns -1 on error
-     */
-    static int createDir(char *path);
-
-    /*!
      * \brief Created a new Command Mode.
      * \param command valid command mode for the resource file, eg "[Engine.OpenGL.Driver]"
      * \returns id given to mode

include/utils/math.h

@@ -45,24 +45,6 @@ bool equalEpsilon(vec_t a, vec_t b);
 int helIntersectionLineAndPolygon(vec3_t intersect, vec3_t p1, vec3_t p2, vec3_t *polygon);
 
 /*!
- * \brief Calculate the distance from a sphere to a plane
- * \param center Center of sphere
- * \param radius Radius of sphere
- * \param plane Plane
- * \returns distance
- */
-vec_t helDistToSphereFromPlane3v(vec3_t center, vec_t radius, vec4_t plane);
-
-/*!
- * \brief Calculate the distance from a box to a plane
- * \param min Minimum Point of a bounding box
- * \param max Maximum Point of a bounding box
- * \param plane Plane
- * \returns distance
- */
-vec_t helDistToBboxFromPlane3v(vec3_t min, vec3_t max, vec4_t plane);
-
-/*!
  * \brief Calculate the length of a line segment / the distance between two points
  * \param a First point
  * \param b Second point

src/OpenRaider.cpp

@@ -2698,6 +2698,8 @@ void OpenRaider::processRoom(int index)
 //! \fixme Use rc_get_bool consistently!
 void OpenRaider::consoleCommand(char *cmd)
 {
+    bool b = false;
+
     if (!cmd || !cmd[0])
         return;
 
@@ -2805,7 +2807,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_animate", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fAnimateAllModels);
             print(false, "Animating all models");
@@ -2818,7 +2821,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_ponytail", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fRenderPonytail);
             print(false, "Rendering ponytail");
@@ -2831,7 +2835,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_light", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fGL_Lights);
         }
@@ -2842,7 +2847,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("hop", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             gWorld.setFlag(World::fEnableHopping);
             print(true, "Room hopping is on");
@@ -2855,7 +2861,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_fog", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fFog);
         }
@@ -2906,7 +2913,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_oneroom", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fOneRoom);
         }
@@ -2917,7 +2925,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_allrooms", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fAllRooms);
         }
@@ -2930,7 +2939,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_sprite", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fSprites);
         }
@@ -2941,7 +2951,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_roommodel", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fRoomModels);
         }
@@ -2952,7 +2963,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_entmodel", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fEntityModels);
         }
@@ -2963,7 +2975,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_particle", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fParticles);
         }
@@ -2974,7 +2987,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_vis", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fUsePortals);
         }
@@ -2985,7 +2999,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_upf", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fUpdateRoomListPerFrame);
         }
@@ -2996,7 +3011,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_portal", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fPortals);
         }
@@ -3007,7 +3023,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_vmodel", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fViewModel);
         }
@@ -3018,7 +3035,8 @@ void OpenRaider::consoleCommand(char *cmd)
     }
     else if (rc_command("r_ralpha", cmd))
     {
-        if (atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (b)
         {
             m_render.setFlags(Render::fRoomAlpha);
         }
@@ -3062,7 +3080,8 @@ void OpenRaider::consoleCommand(char *cmd)
     {
         m_flags |= OpenRaider_ShowFPS;
 
-        if (!atoi(cmd))
+        rc_get_bool(cmd, &b);
+        if (!b)
         {
             m_flags ^= OpenRaider_ShowFPS;
         }

src/System.cpp

@@ -57,14 +57,6 @@ System::System() {
 System::~System() {
 }
 
-int System::createDir(char *path) {
-#ifdef WIN32
-    return _mkdir(path);
-#else
-    return mkdir(path, S_IRWXU | S_IRWXG);
-#endif
-}
-
 unsigned int System::addCommandMode(const char *command) {
     if (command && command[0] == '[') {
         mCmdModes.pushBack(command);

src/utils/math.cpp

@@ -93,45 +93,6 @@ int helIntersectionLineAndPolygon(vec3_t intersect,
 }
 
 
-vec_t helDistToSphereFromPlane3v(vec3_t center, vec_t radius, vec4_t plane)
-{
-    vec_t d;
-
-
-    d = (plane[0] * center[0] +
-            plane[1] * center[1] +
-            plane[2] * center[2] +
-            plane[3]);
-
-    if (d <= -radius)
-        return 0;
-
-    return d + radius;
-}
-
-
-vec_t helDistToBboxFromPlane3v(vec3_t min, vec3_t max, vec4_t plane)
-{
-    vec3_t center;
-    vec_t d, radius;
-
-
-    helMidpoint3v(min, max, center);
-
-    d = (plane[0] * center[0] +
-            plane[1] * center[1] +
-            plane[2] * center[2] +
-            plane[3]);
-
-    radius = helDist3v(max, center);
-
-    if (d <= -radius)
-        return 0;
-
-    return d + radius;
-}
-
-
 vec_t helDist3v(vec3_t a, vec3_t b)
 {
     return (sqrtf( ((b[0] - a[0]) * (b[0] - a[0])) +