compile with -Wextra

firmware/CMakeLists.txt

@@ -58,6 +58,7 @@ target_include_directories(trackball PUBLIC ${CMAKE_CURRENT_BINARY_DIR}/fatfs)
 
 target_compile_options(trackball PUBLIC
     -Wall
+    -Wextra
     -Werror
 )
 

firmware/src/console.c

@@ -163,7 +163,7 @@ void cnsl_init(void) {
 }
 
 static int32_t cnsl_find_line_end(void) {
-    for (int32_t i = 0; i < cnsl_buff_pos; i++) {
+    for (uint32_t i = 0; i < cnsl_buff_pos; i++) {
         if ((cnsl_line_buff[i] == '\r') || (cnsl_line_buff[i] == '\n')) {
             return i;
         }

firmware/src/debug.c

@@ -91,7 +91,7 @@ static void debug_msc_pmw3360_frame(void) {
     } else {
         UINT bw;
         res = f_write(&file, frame, r, &bw);
-        if ((res != FR_OK) || (bw != r)) {
+        if ((res != FR_OK) || ((ssize_t)bw != r)) {
             debug("error: f_write returned %d", res);
         }
     }

firmware/src/log.c

@@ -38,7 +38,7 @@ void log_dump_to_usb(void) {
 
     char buff[32];
     int l = snprintf(buff, sizeof(buff), "\r\n\r\nbuffered log output:\r\n");
-    if ((l > 0) && (l <= sizeof(buff))) {
+    if ((l > 0) && (l <= (int)sizeof(buff))) {
         usb_cdc_write(buff, l);
     }
 
@@ -50,7 +50,7 @@ void log_dump_to_usb(void) {
     }
 
     l = snprintf(buff, sizeof(buff), "\r\n\r\nlive log:\r\n");
-    if ((l > 0) && (l <= sizeof(buff))) {
+    if ((l > 0) && (l <= (int)sizeof(buff))) {
         usb_cdc_write(buff, l);
     }
 }
@@ -94,7 +94,7 @@ static int format_debug_log(char *buff, size_t len, const char *format, va_list
     if (l < 0) {
         // encoding error
         l = snprintf(buff, len, "%s: encoding error\r\n", __func__);
-    } else if (l >= len) {
+    } else if (l >= (ssize_t)len) {
         // not enough space for string
         l = snprintf(buff, len, "%s: message too long (%d)\r\n", __func__, l);
     }
@@ -110,7 +110,7 @@ void debug_log(bool log, const char* format, ...) {
     int l = format_debug_log(line_buff, sizeof(line_buff), format, args);
     va_end(args);
 
-    if ((l > 0) && (l <= sizeof(line_buff))) {
+    if ((l > 0) && (l <= (int)sizeof(line_buff))) {
         usb_cdc_write(line_buff, l);
 
         if (log) {