Browse Source

Use serial shorthand

Scott Lahteine 3 years ago
parent
commit
708ea3d0bb

+ 1
- 2
Marlin/src/MarlinCore.cpp View File

@@ -419,8 +419,7 @@ inline void manage_inactivity(const bool ignore_stepper_queue=false) {
419 419
   if (parked_or_ignoring) gcode.reset_stepper_timeout(ms);
420 420
 
421 421
   if (gcode.stepper_max_timed_out(ms)) {
422
-    SERIAL_ERROR_START();
423
-    SERIAL_ECHOLNPAIR(STR_KILL_INACTIVE_TIME, parser.command_ptr);
422
+    SERIAL_ERROR_MSG(STR_KILL_INACTIVE_TIME, parser.command_ptr);
424 423
     kill();
425 424
   }
426 425
 

+ 3
- 6
Marlin/src/feature/binary_stream.h View File

@@ -352,8 +352,7 @@ public:
352 352
               }
353 353
             }
354 354
             else {
355
-              SERIAL_ECHO_START();
356
-              SERIAL_ECHOLNPAIR("Packet header(", packet.header.sync, "?) corrupt");
355
+              SERIAL_ECHO_MSG("Packet header(", packet.header.sync, "?) corrupt");
357 356
               stream_state = StreamState::PACKET_RESEND;
358 357
             }
359 358
           }
@@ -387,8 +386,7 @@ public:
387 386
               stream_state = StreamState::PACKET_PROCESS;
388 387
             }
389 388
             else {
390
-              SERIAL_ECHO_START();
391
-              SERIAL_ECHOLNPAIR("Packet(", packet.header.sync, ") payload corrupt");
389
+              SERIAL_ECHO_MSG("Packet(", packet.header.sync, ") payload corrupt");
392 390
               stream_state = StreamState::PACKET_RESEND;
393 391
             }
394 392
           }
@@ -406,8 +404,7 @@ public:
406 404
           if (packet_retries < MAX_RETRIES || MAX_RETRIES == 0) {
407 405
             packet_retries++;
408 406
             stream_state = StreamState::PACKET_RESET;
409
-            SERIAL_ECHO_START();
410
-            SERIAL_ECHOLNPAIR("Resend request ", int(packet_retries));
407
+            SERIAL_ECHO_MSG("Resend request ", int(packet_retries));
411 408
             SERIAL_ECHOLNPAIR("rs", sync);
412 409
           }
413 410
           else

+ 1
- 2
Marlin/src/feature/cancel_object.cpp View File

@@ -67,8 +67,7 @@ void CancelObject::uncancel_object(const int8_t obj) {
67 67
 
68 68
 void CancelObject::report() {
69 69
   if (active_object >= 0) {
70
-    SERIAL_ECHO_START();
71
-    SERIAL_ECHOLNPAIR("Active Object: ", int(active_object));
70
+    SERIAL_ECHO_MSG("Active Object: ", int(active_object));
72 71
   }
73 72
 
74 73
   if (canceled) {

+ 3
- 6
Marlin/src/feature/mmu/mmu2.cpp View File

@@ -514,8 +514,7 @@ static void mmu2_not_responding() {
514 514
         extruder = index; // filament change is finished
515 515
         active_extruder = 0;
516 516
         ENABLE_AXIS_E0();
517
-        SERIAL_ECHO_START();
518
-        SERIAL_ECHOLNPAIR(STR_ACTIVE_EXTRUDER, int(extruder));
517
+        SERIAL_ECHO_MSG(STR_ACTIVE_EXTRUDER, int(extruder));
519 518
       }
520 519
       ui.reset_status();
521 520
     }
@@ -602,8 +601,7 @@ static void mmu2_not_responding() {
602 601
       active_extruder = 0;
603 602
 
604 603
       ENABLE_AXIS_E0();
605
-      SERIAL_ECHO_START();
606
-      SERIAL_ECHOLNPAIR(STR_ACTIVE_EXTRUDER, int(extruder));
604
+      SERIAL_ECHO_MSG(STR_ACTIVE_EXTRUDER, int(extruder));
607 605
 
608 606
       ui.reset_status();
609 607
     }
@@ -698,8 +696,7 @@ static void mmu2_not_responding() {
698 696
       extruder = index; //filament change is finished
699 697
       active_extruder = 0;
700 698
       ENABLE_AXIS_E0();
701
-      SERIAL_ECHO_START();
702
-      SERIAL_ECHOLNPAIR(STR_ACTIVE_EXTRUDER, int(extruder));
699
+      SERIAL_ECHO_MSG(STR_ACTIVE_EXTRUDER, int(extruder));
703 700
       ui.reset_status();
704 701
     }
705 702
 

+ 4
- 8
Marlin/src/gcode/bedlevel/mbl/G29.cpp View File

@@ -142,8 +142,7 @@ void GcodeSuite::G29() {
142 142
       if (parser.seenval('I')) {
143 143
         ix = parser.value_int();
144 144
         if (!WITHIN(ix, 0, GRID_MAX_POINTS_X - 1)) {
145
-          SERIAL_ECHOPAIR("I out of range (0-", int(GRID_MAX_POINTS_X - 1));
146
-          SERIAL_ECHOLNPGM(")");
145
+          SERIAL_ECHOLNPAIR("I out of range (0-", int(GRID_MAX_POINTS_X - 1), ")");
147 146
           return;
148 147
         }
149 148
       }
@@ -153,8 +152,7 @@ void GcodeSuite::G29() {
153 152
       if (parser.seenval('J')) {
154 153
         iy = parser.value_int();
155 154
         if (!WITHIN(iy, 0, GRID_MAX_POINTS_Y - 1)) {
156
-          SERIAL_ECHOPAIR("J out of range (0-", int(GRID_MAX_POINTS_Y - 1));
157
-          SERIAL_ECHOLNPGM(")");
155
+          SERIAL_ECHOLNPAIR("J out of range (0-", int(GRID_MAX_POINTS_Y - 1), ")");
158 156
           return;
159 157
         }
160 158
       }
@@ -182,10 +180,8 @@ void GcodeSuite::G29() {
182 180
 
183 181
   } // switch(state)
184 182
 
185
-  if (state == MeshNext) {
186
-    SERIAL_ECHOPAIR("MBL G29 point ", _MIN(mbl_probe_index, GRID_MAX_POINTS));
187
-    SERIAL_ECHOLNPAIR(" of ", int(GRID_MAX_POINTS));
188
-  }
183
+  if (state == MeshNext)
184
+    SERIAL_ECHOLNPAIR("MBL G29 point ", _MIN(mbl_probe_index, GRID_MAX_POINTS), " of ", int(GRID_MAX_POINTS));
189 185
 
190 186
   report_current_position();
191 187
 }

+ 8
- 8
Marlin/src/gcode/config/M281.cpp View File

@@ -34,7 +34,9 @@
34 34
  *  U<angle> - Stowed Angle
35 35
  */
36 36
 void GcodeSuite::M281() {
37
+
37 38
   if (!parser.seenval('P')) return;
39
+
38 40
   const int servo_index = parser.value_int();
39 41
   if (WITHIN(servo_index, 0, NUM_SERVOS - 1)) {
40 42
     #if ENABLED(BLTOUCH)
@@ -53,16 +55,14 @@ void GcodeSuite::M281() {
53 55
       angle_change = true;
54 56
     }
55 57
     if (!angle_change) {
56
-      SERIAL_ECHO_START();
57
-      SERIAL_ECHOLNPAIR(" Servo ", servo_index,
58
-                        " L", servo_angles[servo_index][0],
59
-                        " U", servo_angles[servo_index][1]);
58
+      SERIAL_ECHO_MSG(" Servo ", servo_index,
59
+                      " L", servo_angles[servo_index][0],
60
+                      " U", servo_angles[servo_index][1]);
60 61
     }
61 62
   }
62
-  else {
63
-    SERIAL_ERROR_START();
64
-    SERIAL_ECHOLNPAIR("Servo ", servo_index, " out of range");
65
-  }
63
+  else
64
+    SERIAL_ERROR_MSG("Servo ", servo_index, " out of range");
65
+
66 66
 }
67 67
 
68 68
 #endif // EDITABLE_SERVO_ANGLES

+ 5
- 4
Marlin/src/gcode/config/M304.cpp View File

@@ -35,14 +35,15 @@
35 35
  *  D<dval> - Set the D value
36 36
  */
37 37
 void GcodeSuite::M304() {
38
+
38 39
   if (parser.seen('P')) thermalManager.temp_bed.pid.Kp = parser.value_float();
39 40
   if (parser.seen('I')) thermalManager.temp_bed.pid.Ki = scalePID_i(parser.value_float());
40 41
   if (parser.seen('D')) thermalManager.temp_bed.pid.Kd = scalePID_d(parser.value_float());
41 42
 
42
-  SERIAL_ECHO_START();
43
-  SERIAL_ECHOLNPAIR(" p:", thermalManager.temp_bed.pid.Kp,
44
-                    " i:", unscalePID_i(thermalManager.temp_bed.pid.Ki),
45
-                    " d:", unscalePID_d(thermalManager.temp_bed.pid.Kd));
43
+  SERIAL_ECHO_MSG(" p:", thermalManager.temp_bed.pid.Kp,
44
+                  " i:", unscalePID_i(thermalManager.temp_bed.pid.Ki),
45
+                  " d:", unscalePID_d(thermalManager.temp_bed.pid.Kd));
46
+
46 47
 }
47 48
 
48 49
 #endif // PIDTEMPBED

+ 2
- 4
Marlin/src/gcode/config/M305.cpp View File

@@ -49,10 +49,8 @@ void GcodeSuite::M305() {
49 49
   const bool do_set = parser.seen("BCRT");
50 50
 
51 51
   // A valid P index is required
52
-  if (t_index >= (USER_THERMISTORS) || (do_set && t_index < 0)) {
53
-    SERIAL_ECHO_START();
54
-    SERIAL_ECHOLNPAIR("!Invalid index. (0 <= P <= ", int(USER_THERMISTORS - 1), ")");
55
-  }
52
+  if (t_index >= (USER_THERMISTORS) || (do_set && t_index < 0))
53
+    SERIAL_ECHO_MSG("!Invalid index. (0 <= P <= ", int(USER_THERMISTORS - 1), ")");
56 54
   else if (do_set) {
57 55
     if (parser.seen('R')) // Pullup resistor value
58 56
       if (!thermalManager.set_pull_up_res(t_index, parser.value_float()))

+ 7
- 8
Marlin/src/gcode/control/M280.cpp View File

@@ -31,7 +31,9 @@
31 31
  * M280: Get or set servo position. P<index> [S<angle>]
32 32
  */
33 33
 void GcodeSuite::M280() {
34
+
34 35
   if (!parser.seen('P')) return;
36
+
35 37
   const int servo_index = parser.value_int();
36 38
   if (WITHIN(servo_index, 0, NUM_SERVOS - 1)) {
37 39
     if (parser.seen('S')) {
@@ -41,15 +43,12 @@ void GcodeSuite::M280() {
41 43
       else
42 44
         MOVE_SERVO(servo_index, a);
43 45
     }
44
-    else {
45
-      SERIAL_ECHO_START();
46
-      SERIAL_ECHOLNPAIR(" Servo ", servo_index, ": ", servo[servo_index].read());
47
-    }
48
-  }
49
-  else {
50
-    SERIAL_ERROR_START();
51
-    SERIAL_ECHOLNPAIR("Servo ", servo_index, " out of range");
46
+    else
47
+      SERIAL_ECHO_MSG(" Servo ", servo_index, ": ", servo[servo_index].read());
52 48
   }
49
+  else
50
+    SERIAL_ERROR_MSG("Servo ", servo_index, " out of range");
51
+
53 52
 }
54 53
 
55 54
 #endif // HAS_SERVOS

+ 4
- 4
Marlin/src/gcode/host/M113.cpp View File

@@ -32,14 +32,14 @@
32 32
  *   S<seconds> Optional. Set the keepalive interval.
33 33
  */
34 34
 void GcodeSuite::M113() {
35
+
35 36
   if (parser.seenval('S')) {
36 37
     host_keepalive_interval = parser.value_byte();
37 38
     NOMORE(host_keepalive_interval, 60);
38 39
   }
39
-  else {
40
-    SERIAL_ECHO_START();
41
-    SERIAL_ECHOLNPAIR("M113 S", (unsigned long)host_keepalive_interval);
42
-  }
40
+  else
41
+    SERIAL_ECHO_MSG("M113 S", (uint16_t)host_keepalive_interval);
42
+
43 43
 }
44 44
 
45 45
 #endif // HOST_KEEPALIVE_FEATURE

+ 2
- 4
Marlin/src/gcode/motion/M290.cpp View File

@@ -42,14 +42,12 @@
42 42
   FORCE_INLINE void mod_probe_offset(const float &offs) {
43 43
     if (TERN1(BABYSTEP_HOTEND_Z_OFFSET, active_extruder == 0)) {
44 44
       probe.offset.z += offs;
45
-      SERIAL_ECHO_START();
46
-      SERIAL_ECHOLNPAIR(STR_PROBE_OFFSET " " STR_Z, probe.offset.z);
45
+      SERIAL_ECHO_MSG(STR_PROBE_OFFSET " " STR_Z, probe.offset.z);
47 46
     }
48 47
     else {
49 48
       #if ENABLED(BABYSTEP_HOTEND_Z_OFFSET)
50 49
         hotend_offset[active_extruder].z -= offs;
51
-        SERIAL_ECHO_START();
52
-        SERIAL_ECHOLNPAIR(STR_PROBE_OFFSET STR_Z ": ", hotend_offset[active_extruder].z);
50
+        SERIAL_ECHO_MSG(STR_PROBE_OFFSET STR_Z ": ", hotend_offset[active_extruder].z);
53 51
       #endif
54 52
     }
55 53
   }

+ 1
- 2
Marlin/src/gcode/stats/M31.cpp View File

@@ -35,6 +35,5 @@ void GcodeSuite::M31() {
35 35
 
36 36
   ui.set_status(buffer);
37 37
 
38
-  SERIAL_ECHO_START();
39
-  SERIAL_ECHOLNPAIR("Print time: ", buffer);
38
+  SERIAL_ECHO_MSG("Print time: ", buffer);
40 39
 }

+ 2
- 4
Marlin/src/lcd/extui/lib/anycubic_i3mega/anycubic_i3mega_lcd.cpp View File

@@ -552,10 +552,8 @@ void AnycubicTFTClass::GetCommandFromTFT() {
552 552
         a_command = ((int)((strtod(&TFTcmdbuffer[TFTbufindw][TFTstrchr_pointer - TFTcmdbuffer[TFTbufindw] + 1], nullptr))));
553 553
 
554 554
         #if ENABLED(ANYCUBIC_LCD_DEBUG)
555
-          if ((a_command > 7) && (a_command != 20)) { // No debugging of status polls, please!
556
-            SERIAL_ECHOPGM("TFT Serial Command: ");
557
-            SERIAL_ECHOLN(TFTcmdbuffer[TFTbufindw]);
558
-          }
555
+          if ((a_command > 7) && (a_command != 20))   // No debugging of status polls, please!
556
+            SERIAL_ECHOLNPAIR("TFT Serial Command: ", TFTcmdbuffer[TFTbufindw]);
559 557
         #endif
560 558
 
561 559
         switch (a_command) {

+ 7
- 10
Marlin/src/lcd/extui/lib/ftdi_eve_touch_ui/ftdi_eve_lib/basic/commands.cpp View File

@@ -1074,7 +1074,7 @@ void CLCD::init() {
1074 1074
    uint8_t device_id = mem_read_8(REG::ID);            // Read Device ID, Should Be 0x7C;
1075 1075
    if (device_id == 0x7C) {
1076 1076
      #if ENABLED(TOUCH_UI_DEBUG)
1077
-       SERIAL_ECHO_MSG("FTDI chip initialized ");
1077
+       SERIAL_ECHO_MSG("FTDI chip initialized");
1078 1078
      #endif
1079 1079
      break;
1080 1080
    }
@@ -1082,11 +1082,10 @@ void CLCD::init() {
1082 1082
      delay(1);
1083 1083
 
1084 1084
    if (counter == 249) {
1085
-     #if ENABLED(TOUCH_UI_DEBUG)
1086
-       SERIAL_ECHO_START();
1087
-       SERIAL_ECHOLNPAIR("Timeout waiting for device ID, should be 124, got ", device_id);
1088
-     #endif
1089
-   }
1085
+      #if ENABLED(TOUCH_UI_DEBUG)
1086
+        SERIAL_ECHO_MSG("Timeout waiting for device ID, should be 124, got ", int(device_id));
1087
+      #endif
1088
+    }
1090 1089
   }
1091 1090
 
1092 1091
   /* make sure that all units are in working conditions, usually the touch-controller needs a little more time */
@@ -1101,10 +1100,8 @@ void CLCD::init() {
1101 1100
     else
1102 1101
       delay(1);
1103 1102
 
1104
-    if (ENABLED(TOUCH_UI_DEBUG) && counter == 99) {
1105
-      SERIAL_ECHO_START();
1106
-      SERIAL_ECHOLNPAIR("Timeout waiting for reset status. Should be 0x00, got ", reset_status);
1107
-    }
1103
+    if (ENABLED(TOUCH_UI_DEBUG) && counter == 99)
1104
+      SERIAL_ECHO_MSG("Timeout waiting for reset status. Should be 0x00, got ", int(reset_status));
1108 1105
   }
1109 1106
 
1110 1107
   mem_write_8(REG::PWM_DUTY, 0);   // turn off Backlight, Frequency already is set to 250Hz default

+ 2
- 4
Marlin/src/lcd/extui/lib/ftdi_eve_touch_ui/ftdi_eve_lib/extended/event_loop.cpp View File

@@ -124,8 +124,7 @@ namespace FTDI {
124 124
       case UNPRESSED:
125 125
         if (tag != 0) {
126 126
           #if ENABLED(TOUCH_UI_DEBUG)
127
-            SERIAL_ECHO_START();
128
-            SERIAL_ECHOLNPAIR("Touch start: ", tag);
127
+            SERIAL_ECHO_MSG("Touch start: ", int(tag));
129 128
           #endif
130 129
 
131 130
           pressed_tag = tag;
@@ -186,8 +185,7 @@ namespace FTDI {
186 185
             if (UIData::flags.bits.touch_end_sound) sound.play(unpress_sound);
187 186
 
188 187
             #if ENABLED(TOUCH_UI_DEBUG)
189
-              SERIAL_ECHO_START();
190
-              SERIAL_ECHOLNPAIR("Touch end: ", pressed_tag);
188
+              SERIAL_ECHO_MSG("Touch end: ", int(pressed_tag));
191 189
             #endif
192 190
 
193 191
             const uint8_t saved_pressed_tag = pressed_tag;

+ 1
- 2
Marlin/src/lcd/extui/lib/ftdi_eve_touch_ui/ftdi_eve_lib/extended/screen_types.cpp View File

@@ -43,8 +43,7 @@ void ScreenRef::setScreen(onRedraw_func_t onRedraw_ptr) {
43 43
   if (type != 0xFF) {
44 44
     setType(type);
45 45
     #if ENABLED(TOUCH_UI_DEBUG)
46
-      SERIAL_ECHO_START();
47
-      SERIAL_ECHOLNPAIR("New screen: ", type);
46
+      SERIAL_ECHO_MSG("New screen: ", int(type));
48 47
     #endif
49 48
   }
50 49
 }

+ 1
- 2
Marlin/src/lcd/extui/lib/ftdi_eve_touch_ui/screens/bio_printing_dialog_box.cpp View File

@@ -127,8 +127,7 @@ void BioPrintingDialogBox::setStatusMessage(const char* message) {
127 127
   storeBackground();
128 128
 
129 129
   #if ENABLED(TOUCH_UI_DEBUG)
130
-    SERIAL_ECHO_START();
131
-    SERIAL_ECHOLNPAIR("New status message: ", message);
130
+    SERIAL_ECHO_MSG("New status message: ", message);
132 131
   #endif
133 132
 
134 133
   if (AT_SCREEN(BioPrintingDialogBox))

+ 25
- 37
Marlin/src/module/settings.cpp View File

@@ -2946,7 +2946,7 @@ void MarlinSettings::reset() {
2946 2946
   }
2947 2947
 
2948 2948
   #define CONFIG_ECHO_START()       do{ if (!forReplay) SERIAL_ECHO_START(); }while(0)
2949
-  #define CONFIG_ECHO_MSG(STR)      do{ CONFIG_ECHO_START(); SERIAL_ECHOLNPGM(STR); }while(0)
2949
+  #define CONFIG_ECHO_MSG(V...)     do{ CONFIG_ECHO_START(); SERIAL_ECHOLNPAIR(V); }while(0)
2950 2950
   #define CONFIG_ECHO_HEADING(STR)  config_heading(forReplay, PSTR(STR))
2951 2951
 
2952 2952
   #if HAS_TRINAMIC_CONFIG
@@ -3039,26 +3039,24 @@ void MarlinSettings::reset() {
3039 3039
       }
3040 3040
 
3041 3041
       #if EXTRUDERS == 1
3042
-        CONFIG_ECHO_START();
3043
-        SERIAL_ECHOLNPAIR("  M200 S", int(parser.volumetric_enabled)
3044
-                              , " D", LINEAR_UNIT(planner.filament_size[0])
3042
+        CONFIG_ECHO_MSG("  M200 S", int(parser.volumetric_enabled)
3043
+                            , " D", LINEAR_UNIT(planner.filament_size[0])
3044
+                            #if ENABLED(VOLUMETRIC_EXTRUDER_LIMIT)
3045
+                              , " L", LINEAR_UNIT(planner.volumetric_extruder_limit[0])
3046
+                            #endif
3047
+                       );
3048
+      #else
3049
+        LOOP_L_N(i, EXTRUDERS) {
3050
+          CONFIG_ECHO_MSG("  M200 T", int(i)
3051
+                              , " D", LINEAR_UNIT(planner.filament_size[i])
3045 3052
                               #if ENABLED(VOLUMETRIC_EXTRUDER_LIMIT)
3046
-                                , " L", LINEAR_UNIT(planner.volumetric_extruder_limit[0])
3053
+                                , " L", LINEAR_UNIT(planner.volumetric_extruder_limit[i])
3047 3054
                               #endif
3048 3055
                          );
3049
-      #else
3050
-        LOOP_L_N(i, EXTRUDERS) {
3051
-          CONFIG_ECHO_START();
3052
-          SERIAL_ECHOLNPAIR("  M200 T", int(i)
3053
-                                , " D", LINEAR_UNIT(planner.filament_size[i])
3054
-                                #if ENABLED(VOLUMETRIC_EXTRUDER_LIMIT)
3055
-                                  , " L", LINEAR_UNIT(planner.volumetric_extruder_limit[i])
3056
-                                #endif
3057
-                           );
3058 3056
         }
3059
-        CONFIG_ECHO_START();
3060
-        SERIAL_ECHOLNPAIR("  M200 S", int(parser.volumetric_enabled));
3057
+        CONFIG_ECHO_MSG("  M200 S", int(parser.volumetric_enabled));
3061 3058
       #endif
3059
+
3062 3060
     #endif // EXTRUDERS && !NO_VOLUMETRICS
3063 3061
 
3064 3062
     CONFIG_ECHO_HEADING("Steps per unit:");
@@ -3194,7 +3192,7 @@ void MarlinSettings::reset() {
3194 3192
 
3195 3193
       CONFIG_ECHO_START();
3196 3194
       SERIAL_ECHOLNPAIR_P(
3197
-        PSTR("  M420 S"), planner.leveling_active ? 1 : 0
3195
+        PSTR("  M420 S"), int(planner.leveling_active)
3198 3196
         #if ENABLED(ENABLE_LEVELING_FADE_HEIGHT)
3199 3197
           , SP_Z_STR, LINEAR_UNIT(planner.z_fade_height)
3200 3198
         #endif
@@ -3260,8 +3258,7 @@ void MarlinSettings::reset() {
3260 3258
           #elif ENABLED(BLTOUCH) || (HAS_Z_SERVO_PROBE && defined(Z_SERVO_ANGLES))
3261 3259
             case Z_PROBE_SERVO_NR:
3262 3260
           #endif
3263
-            CONFIG_ECHO_START();
3264
-            SERIAL_ECHOLNPAIR("  M281 P", int(i), " L", servo_angles[i][0], " U", servo_angles[i][1]);
3261
+            CONFIG_ECHO_MSG("  M281 P", int(i), " L", servo_angles[i][0], " U", servo_angles[i][1]);
3265 3262
           default: break;
3266 3263
         }
3267 3264
       }
@@ -3382,8 +3379,7 @@ void MarlinSettings::reset() {
3382 3379
       #endif // PIDTEMP
3383 3380
 
3384 3381
       #if ENABLED(PIDTEMPBED)
3385
-        CONFIG_ECHO_START();
3386
-        SERIAL_ECHOLNPAIR(
3382
+        CONFIG_ECHO_MSG(
3387 3383
             "  M304 P", thermalManager.temp_bed.pid.Kp
3388 3384
           , " I", unscalePID_i(thermalManager.temp_bed.pid.Ki)
3389 3385
           , " D", unscalePID_d(thermalManager.temp_bed.pid.Kd)
@@ -3400,16 +3396,14 @@ void MarlinSettings::reset() {
3400 3396
 
3401 3397
     #if HAS_LCD_CONTRAST
3402 3398
       CONFIG_ECHO_HEADING("LCD Contrast:");
3403
-      CONFIG_ECHO_START();
3404
-      SERIAL_ECHOLNPAIR("  M250 C", ui.contrast);
3399
+      CONFIG_ECHO_MSG("  M250 C", ui.contrast);
3405 3400
     #endif
3406 3401
 
3407 3402
     TERN_(CONTROLLER_FAN_EDITABLE, M710_report(forReplay));
3408 3403
 
3409 3404
     #if ENABLED(POWER_LOSS_RECOVERY)
3410 3405
       CONFIG_ECHO_HEADING("Power-Loss Recovery:");
3411
-      CONFIG_ECHO_START();
3412
-      SERIAL_ECHOLNPAIR("  M413 S", int(recovery.enabled));
3406
+      CONFIG_ECHO_MSG("  M413 S", int(recovery.enabled));
3413 3407
     #endif
3414 3408
 
3415 3409
     #if ENABLED(FWRETRACT)
@@ -3424,8 +3418,7 @@ void MarlinSettings::reset() {
3424 3418
       );
3425 3419
 
3426 3420
       CONFIG_ECHO_HEADING("Recover: S<length> F<units/m>");
3427
-      CONFIG_ECHO_START();
3428
-      SERIAL_ECHOLNPAIR(
3421
+      CONFIG_ECHO_MSG(
3429 3422
           "  M208 S", LINEAR_UNIT(fwretract.settings.retract_recover_extra)
3430 3423
         , " W", LINEAR_UNIT(fwretract.settings.swap_retract_recover_extra)
3431 3424
         , " F", LINEAR_UNIT(MMS_TO_MMM(fwretract.settings.retract_recover_feedrate_mm_s))
@@ -3434,8 +3427,7 @@ void MarlinSettings::reset() {
3434 3427
       #if ENABLED(FWRETRACT_AUTORETRACT)
3435 3428
 
3436 3429
         CONFIG_ECHO_HEADING("Auto-Retract: S=0 to disable, 1 to interpret E-only moves as retract/recover");
3437
-        CONFIG_ECHO_START();
3438
-        SERIAL_ECHOLNPAIR("  M209 S", fwretract.autoretract_enabled ? 1 : 0);
3430
+        CONFIG_ECHO_MSG("  M209 S", int(fwretract.autoretract_enabled));
3439 3431
 
3440 3432
       #endif // FWRETRACT_AUTORETRACT
3441 3433
 
@@ -3780,13 +3772,10 @@ void MarlinSettings::reset() {
3780 3772
     #if ENABLED(LIN_ADVANCE)
3781 3773
       CONFIG_ECHO_HEADING("Linear Advance:");
3782 3774
       #if EXTRUDERS < 2
3783
-        CONFIG_ECHO_START();
3784
-        SERIAL_ECHOLNPAIR("  M900 K", planner.extruder_advance_K[0]);
3775
+        CONFIG_ECHO_MSG("  M900 K", planner.extruder_advance_K[0]);
3785 3776
       #else
3786
-        LOOP_L_N(i, EXTRUDERS) {
3787
-          CONFIG_ECHO_START();
3788
-          SERIAL_ECHOLNPAIR("  M900 T", int(i), " K", planner.extruder_advance_K[i]);
3789
-        }
3777
+        LOOP_L_N(i, EXTRUDERS)
3778
+          CONFIG_ECHO_MSG("  M900 T", int(i), " K", planner.extruder_advance_K[i]);
3790 3779
       #endif
3791 3780
     #endif
3792 3781
 
@@ -3851,8 +3840,7 @@ void MarlinSettings::reset() {
3851 3840
 
3852 3841
     #if HAS_FILAMENT_SENSOR
3853 3842
       CONFIG_ECHO_HEADING("Filament runout sensor:");
3854
-      CONFIG_ECHO_START();
3855
-      SERIAL_ECHOLNPAIR(
3843
+      CONFIG_ECHO_MSG(
3856 3844
         "  M412 S", int(runout.enabled)
3857 3845
         #if HAS_FILAMENT_RUNOUT_DISTANCE
3858 3846
           , " D", LINEAR_UNIT(runout.runout_distance())

+ 1
- 2
Marlin/src/module/temperature.cpp View File

@@ -1037,8 +1037,7 @@ void Temperature::min_temp_error(const heater_id_t heater_id) {
1037 1037
 
1038 1038
     #if ENABLED(PID_BED_DEBUG)
1039 1039
     {
1040
-      SERIAL_ECHO_START();
1041
-      SERIAL_ECHOLNPAIR(
1040
+      SERIAL_ECHO_MSG(
1042 1041
         " PID_BED_DEBUG : Input ", temp_bed.celsius, " Output ", pid_output,
1043 1042
         #if DISABLED(PID_OPENLOOP)
1044 1043
           STR_PID_DEBUG_PTERM, work_pid.Kp,

+ 1
- 2
Marlin/src/module/tool_change.cpp View File

@@ -1196,8 +1196,7 @@ void tool_change(const uint8_t new_tool, bool no_move/*=false*/) {
1196 1196
         gcode.process_subcommands_now_P(PSTR(EVENT_GCODE_AFTER_TOOLCHANGE));
1197 1197
     #endif
1198 1198
 
1199
-    SERIAL_ECHO_START();
1200
-    SERIAL_ECHOLNPAIR(STR_ACTIVE_EXTRUDER, int(active_extruder));
1199
+    SERIAL_ECHO_MSG(STR_ACTIVE_EXTRUDER, int(active_extruder));
1201 1200
 
1202 1201
   #endif // HAS_MULTI_EXTRUDER
1203 1202
 }

+ 6
- 10
Marlin/src/sd/cardreader.cpp View File

@@ -270,10 +270,9 @@ void CardReader::printListing(SdFile parent, const char * const prepend/*=nullpt
270 270
       // Get a new directory object using the full path
271 271
       // and dive recursively into it.
272 272
       SdFile child;
273
-      if (!child.open(&parent, dosFilename, O_READ)) {
274
-        SERIAL_ECHO_START();
275
-        SERIAL_ECHOLNPAIR(STR_SD_CANT_OPEN_SUBDIR, dosFilename);
276
-      }
273
+      if (!child.open(&parent, dosFilename, O_READ))
274
+        SERIAL_ECHO_MSG(STR_SD_CANT_OPEN_SUBDIR, dosFilename);
275
+
277 276
       printListing(child, path);
278 277
       // close() is done automatically by destructor of SdFile
279 278
     }
@@ -594,8 +593,7 @@ void CardReader::openFileRead(char * const path, const uint8_t subcall_type/*=0*
594 593
         filespos[file_subcall_ctr] = sdpos;
595 594
 
596 595
         // For sub-procedures say 'SUBROUTINE CALL target: "..." parent: "..." pos12345'
597
-        SERIAL_ECHO_START();
598
-        SERIAL_ECHOLNPAIR("SUBROUTINE CALL target:\"", path, "\" parent:\"", proc_filenames[file_subcall_ctr], "\" pos", sdpos);
596
+        SERIAL_ECHO_MSG("SUBROUTINE CALL target:\"", path, "\" parent:\"", proc_filenames[file_subcall_ctr], "\" pos", sdpos);
599 597
         file_subcall_ctr++;
600 598
         break;
601 599
 
@@ -941,10 +939,8 @@ void CardReader::cd(const char * relpath) {
941 939
       workDirParents[workDirDepth++] = workDir;
942 940
     TERN_(SDCARD_SORT_ALPHA, presort());
943 941
   }
944
-  else {
945
-    SERIAL_ECHO_START();
946
-    SERIAL_ECHOLNPAIR(STR_SD_CANT_ENTER_SUBDIR, relpath);
947
-  }
942
+  else
943
+    SERIAL_ECHO_MSG(STR_SD_CANT_ENTER_SUBDIR, relpath);
948 944
 }
949 945
 
950 946
 int8_t CardReader::cdup() {

Loading…
Cancel
Save