Преглед на файлове

HIGH/LOW naming of pin state settings (#19089)

Giuliano Zaro преди 3 години
родител
ревизия
8652a7bdd2
No account linked to committer's email address

+ 1
- 1
Marlin/Configuration.h Целия файл

330
 //#define PSU_NAME "Power Supply"
330
 //#define PSU_NAME "Power Supply"
331
 
331
 
332
 #if ENABLED(PSU_CONTROL)
332
 #if ENABLED(PSU_CONTROL)
333
-  #define PSU_ACTIVE_HIGH false     // Set 'false' for ATX, 'true' for X-Box
333
+  #define PSU_ACTIVE_STATE LOW      // Set 'LOW' for ATX, 'HIGH' for X-Box
334
 
334
 
335
   //#define PSU_DEFAULT_OFF         // Keep power off until enabled directly with M80
335
   //#define PSU_DEFAULT_OFF         // Keep power off until enabled directly with M80
336
   //#define PSU_POWERUP_DELAY 250   // (ms) Delay for the PSU to warm up to full power
336
   //#define PSU_POWERUP_DELAY 250   // (ms) Delay for the PSU to warm up to full power

+ 1
- 1
Marlin/Configuration_adv.h Целия файл

2851
 //#define SPINDLE_FEATURE
2851
 //#define SPINDLE_FEATURE
2852
 //#define LASER_FEATURE
2852
 //#define LASER_FEATURE
2853
 #if EITHER(SPINDLE_FEATURE, LASER_FEATURE)
2853
 #if EITHER(SPINDLE_FEATURE, LASER_FEATURE)
2854
-  #define SPINDLE_LASER_ACTIVE_HIGH     false  // Set to "true" if the on/off function is active HIGH
2854
+  #define SPINDLE_LASER_ACTIVE_STATE    LOW    // Set to "HIGH" if the on/off function is active HIGH
2855
   #define SPINDLE_LASER_PWM             true   // Set to "true" if your controller supports setting the speed/power
2855
   #define SPINDLE_LASER_PWM             true   // Set to "true" if your controller supports setting the speed/power
2856
   #define SPINDLE_LASER_PWM_INVERT      false  // Set to "true" if the speed/power goes up when you want it to go slower
2856
   #define SPINDLE_LASER_PWM_INVERT      false  // Set to "true" if the speed/power goes up when you want it to go slower
2857
 
2857
 

+ 1
- 1
Marlin/src/HAL/DUE/usb/arduino_due_x.h Целия файл

93
 #define USB_VBOF_GPIO               (PIO_PB10_IDX)
93
 #define USB_VBOF_GPIO               (PIO_PB10_IDX)
94
 #define USB_VBOF_FLAGS              (PIO_PERIPH_A | PIO_DEFAULT)
94
 #define USB_VBOF_FLAGS              (PIO_PERIPH_A | PIO_DEFAULT)
95
 /*! Active level of the USB_VBOF output pin. */
95
 /*! Active level of the USB_VBOF output pin. */
96
-#define USB_VBOF_ACTIVE_LEVEL       LOW
96
+#define USB_VBOF_ACTIVE_STATE       LOW
97
 /* ------------------------------------------------------------------------ */
97
 /* ------------------------------------------------------------------------ */

+ 2
- 2
Marlin/src/MarlinCore.h Целия файл

89
 
89
 
90
 #if ENABLED(PSU_CONTROL)
90
 #if ENABLED(PSU_CONTROL)
91
   extern bool powersupply_on;
91
   extern bool powersupply_on;
92
-  #define PSU_PIN_ON()  do{ OUT_WRITE(PS_ON_PIN,  PSU_ACTIVE_HIGH); powersupply_on = true; }while(0)
93
-  #define PSU_PIN_OFF() do{ OUT_WRITE(PS_ON_PIN, !PSU_ACTIVE_HIGH); powersupply_on = false; }while(0)
92
+  #define PSU_PIN_ON()  do{ OUT_WRITE(PS_ON_PIN,  PSU_ACTIVE_STATE); powersupply_on = true;  }while(0)
93
+  #define PSU_PIN_OFF() do{ OUT_WRITE(PS_ON_PIN, !PSU_ACTIVE_STATE); powersupply_on = false; }while(0)
94
   #if ENABLED(AUTO_POWER_CONTROL)
94
   #if ENABLED(AUTO_POWER_CONTROL)
95
     #define PSU_ON()  powerManager.power_on()
95
     #define PSU_ON()  powerManager.power_on()
96
     #define PSU_OFF() powerManager.power_off()
96
     #define PSU_OFF() powerManager.power_off()

+ 6
- 6
Marlin/src/feature/spindle_laser.cpp Целия файл

37
                SpindleLaser::unitPower;                               // LCD status power in PWM, PERCENT, or RPM
37
                SpindleLaser::unitPower;                               // LCD status power in PWM, PERCENT, or RPM
38
 
38
 
39
 #if ENABLED(MARLIN_DEV_MODE)
39
 #if ENABLED(MARLIN_DEV_MODE)
40
-  cutter_frequency_t SpindleLaser::frequency;                         // setting PWM frequency; range: 2K - 50K
40
+  cutter_frequency_t SpindleLaser::frequency;                         // PWM frequency setting; range: 2K - 50K
41
 #endif
41
 #endif
42
 #define SPINDLE_LASER_PWM_OFF ((SPINDLE_LASER_PWM_INVERT) ? 255 : 0)
42
 #define SPINDLE_LASER_PWM_OFF ((SPINDLE_LASER_PWM_INVERT) ? 255 : 0)
43
 
43
 
45
 // Init the cutter to a safe OFF state
45
 // Init the cutter to a safe OFF state
46
 //
46
 //
47
 void SpindleLaser::init() {
47
 void SpindleLaser::init() {
48
-  OUT_WRITE(SPINDLE_LASER_ENA_PIN, !SPINDLE_LASER_ACTIVE_HIGH);       // Init spindle to off
48
+  OUT_WRITE(SPINDLE_LASER_ENA_PIN, !SPINDLE_LASER_ACTIVE_STATE);      // Init spindle to off
49
   #if ENABLED(SPINDLE_CHANGE_DIR)
49
   #if ENABLED(SPINDLE_CHANGE_DIR)
50
     OUT_WRITE(SPINDLE_DIR_PIN, SPINDLE_INVERT_DIR ? 255 : 0);         // Init rotation to clockwise (M3)
50
     OUT_WRITE(SPINDLE_DIR_PIN, SPINDLE_INVERT_DIR ? 255 : 0);         // Init rotation to clockwise (M3)
51
   #endif
51
   #endif
52
   #if ENABLED(SPINDLE_LASER_PWM)
52
   #if ENABLED(SPINDLE_LASER_PWM)
53
     SET_PWM(SPINDLE_LASER_PWM_PIN);
53
     SET_PWM(SPINDLE_LASER_PWM_PIN);
54
-    analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_PWM_OFF); // set to lowest speed
54
+    analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_PWM_OFF); // Set to lowest speed
55
   #endif
55
   #endif
56
   #if ENABLED(HAL_CAN_SET_PWM_FREQ) && defined(SPINDLE_LASER_FREQUENCY)
56
   #if ENABLED(HAL_CAN_SET_PWM_FREQ) && defined(SPINDLE_LASER_FREQUENCY)
57
     set_pwm_frequency(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_FREQUENCY);
57
     set_pwm_frequency(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_FREQUENCY);
64
    * Set the cutter PWM directly to the given ocr value
64
    * Set the cutter PWM directly to the given ocr value
65
    */
65
    */
66
   void SpindleLaser::set_ocr(const uint8_t ocr) {
66
   void SpindleLaser::set_ocr(const uint8_t ocr) {
67
-    WRITE(SPINDLE_LASER_ENA_PIN, SPINDLE_LASER_ACTIVE_HIGH);        // turn spindle on
67
+    WRITE(SPINDLE_LASER_ENA_PIN, SPINDLE_LASER_ACTIVE_STATE);         // Turn spindle on
68
     analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), ocr ^ SPINDLE_LASER_PWM_OFF);
68
     analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), ocr ^ SPINDLE_LASER_PWM_OFF);
69
     #if NEEDS_HARDWARE_PWM && SPINDLE_LASER_FREQUENCY
69
     #if NEEDS_HARDWARE_PWM && SPINDLE_LASER_FREQUENCY
70
       set_pwm_duty(pin_t(SPINDLE_LASER_PWM_PIN), ocr ^ SPINDLE_LASER_PWM_OFF);
70
       set_pwm_duty(pin_t(SPINDLE_LASER_PWM_PIN), ocr ^ SPINDLE_LASER_PWM_OFF);
71
     #endif
71
     #endif
72
   }
72
   }
73
   void SpindleLaser::ocr_off() {
73
   void SpindleLaser::ocr_off() {
74
-    WRITE(SPINDLE_LASER_ENA_PIN, !SPINDLE_LASER_ACTIVE_HIGH);       // Turn spindle off
74
+    WRITE(SPINDLE_LASER_ENA_PIN, !SPINDLE_LASER_ACTIVE_STATE);        // Turn spindle off
75
     analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_PWM_OFF); // Only write low byte
75
     analogWrite(pin_t(SPINDLE_LASER_PWM_PIN), SPINDLE_LASER_PWM_OFF); // Only write low byte
76
   }
76
   }
77
 #endif
77
 #endif
98
       isReady = false;
98
       isReady = false;
99
     }
99
     }
100
   #else
100
   #else
101
-    WRITE(SPINDLE_LASER_ENA_PIN, enabled() == SPINDLE_LASER_ACTIVE_HIGH);
101
+    WRITE(SPINDLE_LASER_ENA_PIN, enabled() ? SPINDLE_LASER_ACTIVE_STATE : !SPINDLE_LASER_ACTIVE_STATE);
102
     isReady = true;
102
     isReady = true;
103
   #endif
103
   #endif
104
 }
104
 }

+ 1
- 1
Marlin/src/inc/Conditionals_post.h Целия файл

403
 #ifndef PSU_NAME
403
 #ifndef PSU_NAME
404
   #if DISABLED(PSU_CONTROL)
404
   #if DISABLED(PSU_CONTROL)
405
     #define PSU_NAME "Generic"  // No control
405
     #define PSU_NAME "Generic"  // No control
406
-  #elif PSU_ACTIVE_HIGH
406
+  #elif PSU_ACTIVE_STATE
407
     #define PSU_NAME "XBox"     // X-Box 360 (203W)
407
     #define PSU_NAME "XBox"     // X-Box 360 (203W)
408
   #else
408
   #else
409
     #define PSU_NAME "ATX"      // ATX style
409
     #define PSU_NAME "ATX"      // ATX style

+ 9
- 5
Marlin/src/inc/SanityCheck.h Целия файл

419
   #error "SPINDLE_DIR_CHANGE is now SPINDLE_CHANGE_DIR. Please update your Configuration_adv.h."
419
   #error "SPINDLE_DIR_CHANGE is now SPINDLE_CHANGE_DIR. Please update your Configuration_adv.h."
420
 #elif defined(SPINDLE_STOP_ON_DIR_CHANGE)
420
 #elif defined(SPINDLE_STOP_ON_DIR_CHANGE)
421
   #error "SPINDLE_STOP_ON_DIR_CHANGE is now SPINDLE_CHANGE_DIR_STOP. Please update your Configuration_adv.h."
421
   #error "SPINDLE_STOP_ON_DIR_CHANGE is now SPINDLE_CHANGE_DIR_STOP. Please update your Configuration_adv.h."
422
+#elif defined(SPINDLE_LASER_ACTIVE_HIGH)
423
+  #error "SPINDLE_LASER_ACTIVE_HIGH is now SPINDLE_LASER_ACTIVE_STATE. Please update your Configuration_adv.h."
422
 #elif defined(SPINDLE_LASER_ENABLE_INVERT)
424
 #elif defined(SPINDLE_LASER_ENABLE_INVERT)
423
-  #error "SPINDLE_LASER_ENABLE_INVERT is now SPINDLE_LASER_ACTIVE_HIGH. Please update your Configuration_adv.h."
425
+  #error "SPINDLE_LASER_ENABLE_INVERT is now SPINDLE_LASER_ACTIVE_STATE. Please update your Configuration_adv.h."
424
 #elif defined(CUTTER_POWER_DISPLAY)
426
 #elif defined(CUTTER_POWER_DISPLAY)
425
   #error "CUTTER_POWER_DISPLAY is now CUTTER_POWER_UNIT. Please update your Configuration_adv.h."
427
   #error "CUTTER_POWER_DISPLAY is now CUTTER_POWER_UNIT. Please update your Configuration_adv.h."
426
 #elif defined(CHAMBER_HEATER_PIN)
428
 #elif defined(CHAMBER_HEATER_PIN)
441
   #error "USB_SD_DISABLED is now NO_SD_HOST_DRIVE. Please update your Configuration_adv.h."
443
   #error "USB_SD_DISABLED is now NO_SD_HOST_DRIVE. Please update your Configuration_adv.h."
442
 #elif defined(USB_SD_ONBOARD)
444
 #elif defined(USB_SD_ONBOARD)
443
   #error "USB_SD_ONBOARD is obsolete. Disable NO_SD_HOST_DRIVE instead."
445
   #error "USB_SD_ONBOARD is obsolete. Disable NO_SD_HOST_DRIVE instead."
446
+#elif defined(PSU_ACTIVE_HIGH)
447
+  #error "PSU_ACTIVE_HIGH is now PSU_ACTIVE_STATE. Please update your configuration."
444
 #elif POWER_SUPPLY == 1
448
 #elif POWER_SUPPLY == 1
445
-  #error "Replace POWER_SUPPLY 1 by enabling PSU_CONTROL and setting PSU_ACTIVE_HIGH to 'false'."
449
+  #error "Replace POWER_SUPPLY 1 by enabling PSU_CONTROL and setting PSU_ACTIVE_STATE to 'LOW'."
446
 #elif POWER_SUPPLY == 2
450
 #elif POWER_SUPPLY == 2
447
-  #error "Replace POWER_SUPPLY 2 by enabling PSU_CONTROL and setting PSU_ACTIVE_HIGH to 'true'."
451
+  #error "Replace POWER_SUPPLY 2 by enabling PSU_CONTROL and setting PSU_ACTIVE_STATE to 'HIGH'."
448
 #elif defined(POWER_SUPPLY)
452
 #elif defined(POWER_SUPPLY)
449
   #error "POWER_SUPPLY is now obsolete. Please remove it from Configuration.h."
453
   #error "POWER_SUPPLY is now obsolete. Please remove it from Configuration.h."
450
 #elif defined(MKS_ROBIN_TFT)
454
 #elif defined(MKS_ROBIN_TFT)
2923
  * Ensure this option is set intentionally
2927
  * Ensure this option is set intentionally
2924
  */
2928
  */
2925
 #if ENABLED(PSU_CONTROL)
2929
 #if ENABLED(PSU_CONTROL)
2926
-  #ifndef PSU_ACTIVE_HIGH
2927
-    #error "PSU_CONTROL requires PSU_ACTIVE_HIGH to be defined as 'true' or 'false'."
2930
+  #ifndef PSU_ACTIVE_STATE
2931
+    #error "PSU_CONTROL requires PSU_ACTIVE_STATE to be defined as 'HIGH' or 'LOW'."
2928
   #elif !PIN_EXISTS(PS_ON)
2932
   #elif !PIN_EXISTS(PS_ON)
2929
     #error "PSU_CONTROL requires PS_ON_PIN."
2933
     #error "PSU_CONTROL requires PS_ON_PIN."
2930
   #endif
2934
   #endif

Loading…
Отказ
Запис