Browse Source

A few constants where they belong

Scott Lahteine 9 years ago
parent
commit
b726511a3b
4 changed files with 12 additions and 10 deletions
  1. 2
    2
      Marlin/Marlin_main.cpp
  2. 3
    1
      Marlin/SdFatConfig.h
  3. 5
    5
      Marlin/cardreader.cpp
  4. 2
    2
      Marlin/cardreader.h

+ 2
- 2
Marlin/Marlin_main.cpp View File

@@ -429,7 +429,7 @@ void enquecommand(const char *cmd)
429 429
     //this is dangerous if a mixing of serial and this happens
430 430
     strcpy(&(cmdbuffer[bufindw][0]),cmd);
431 431
     SERIAL_ECHO_START;
432
-    SERIAL_ECHOPGM("enqueing \"");
432
+    SERIAL_ECHOPGM(MSG_Enqueing);
433 433
     SERIAL_ECHO(cmdbuffer[bufindw]);
434 434
     SERIAL_ECHOLNPGM("\"");
435 435
     bufindw= (bufindw + 1)%BUFSIZE;
@@ -444,7 +444,7 @@ void enquecommand_P(const char *cmd)
444 444
     //this is dangerous if a mixing of serial and this happens
445 445
     strcpy_P(&(cmdbuffer[bufindw][0]),cmd);
446 446
     SERIAL_ECHO_START;
447
-    SERIAL_ECHOPGM("enqueing \"");
447
+    SERIAL_ECHOPGM(MSG_Enqueing);
448 448
     SERIAL_ECHO(cmdbuffer[bufindw]);
449 449
     SERIAL_ECHOLNPGM("\"");
450 450
     bufindw= (bufindw + 1)%BUFSIZE;

+ 3
- 1
Marlin/SdFatConfig.h View File

@@ -113,8 +113,10 @@ uint8_t const SOFT_SPI_SCK_PIN = 13;
113 113
  */
114 114
 /** Number of VFAT entries used. Every entry has 13 UTF-16 characters */
115 115
 #define MAX_VFAT_ENTRIES (2)
116
+/** Number of UTF-16 characters per entry */
117
+#define FILENAME_LENGTH 13
116 118
 /** Total size of the buffer used to store the long filenames */
117
-#define LONG_FILENAME_LENGTH (13*MAX_VFAT_ENTRIES+1)
119
+#define LONG_FILENAME_LENGTH (FILENAME_LENGTH*MAX_VFAT_ENTRIES+1)
118 120
 #endif  // SdFatConfig_h
119 121
 
120 122
 

+ 5
- 5
Marlin/cardreader.cpp View File

@@ -60,8 +60,8 @@ void  CardReader::lsDive(const char *prepend,SdFile parent)
60 60
     if( DIR_IS_SUBDIR(&p) && lsAction!=LS_Count && lsAction!=LS_GetFilename) // hence LS_SerialPrint
61 61
     {
62 62
 
63
-      char path[13*2];
64
-      char lfilename[13];
63
+      char path[FILENAME_LENGTH*2];
64
+      char lfilename[FILENAME_LENGTH];
65 65
       createFilename(lfilename,p);
66 66
       
67 67
       path[0]=0;
@@ -235,7 +235,7 @@ void CardReader::getAbsFilename(char *t)
235 235
     while(*t!=0 && cnt< MAXPATHNAMELENGTH) 
236 236
     {t++;cnt++;}  //crawl counter forward.
237 237
   }
238
-  if(cnt<MAXPATHNAMELENGTH-13)
238
+  if(cnt<MAXPATHNAMELENGTH-FILENAME_LENGTH)
239 239
     file.getFilename(t);
240 240
   else
241 241
     t[0]=0;
@@ -305,7 +305,7 @@ void CardReader::openFile(char* name,bool read, bool replace_current/*=true*/)
305 305
       //SERIAL_ECHO("end  :");SERIAL_ECHOLN((int)(dirname_end-name));
306 306
       if(dirname_end>0 && dirname_end>dirname_start)
307 307
       {
308
-        char subdirname[13];
308
+        char subdirname[FILENAME_LENGTH];
309 309
         strncpy(subdirname, dirname_start, dirname_end-dirname_start);
310 310
         subdirname[dirname_end-dirname_start]=0;
311 311
         SERIAL_ECHOLN(subdirname);
@@ -401,7 +401,7 @@ void CardReader::removeFile(char* name)
401 401
       //SERIAL_ECHO("end  :");SERIAL_ECHOLN((int)(dirname_end-name));
402 402
       if(dirname_end>0 && dirname_end>dirname_start)
403 403
       {
404
-        char subdirname[13];
404
+        char subdirname[FILENAME_LENGTH];
405 405
         strncpy(subdirname, dirname_start, dirname_end-dirname_start);
406 406
         subdirname[dirname_end-dirname_start]=0;
407 407
         SERIAL_ECHOLN(subdirname);

+ 2
- 2
Marlin/cardreader.h View File

@@ -52,7 +52,7 @@ public:
52 52
   bool logging;
53 53
   bool sdprinting ;  
54 54
   bool cardOK ;
55
-  char filename[13];
55
+  char filename[FILENAME_LENGTH];
56 56
   char longFilename[LONG_FILENAME_LENGTH];
57 57
   bool filenameIsDir;
58 58
   int lastnr; //last number of the autostart;
@@ -63,7 +63,7 @@ private:
63 63
   SdVolume volume;
64 64
   SdFile file;
65 65
   #define SD_PROCEDURE_DEPTH 1
66
-  #define MAXPATHNAMELENGTH (13*MAX_DIR_DEPTH+MAX_DIR_DEPTH+1)
66
+  #define MAXPATHNAMELENGTH (FILENAME_LENGTH*MAX_DIR_DEPTH+MAX_DIR_DEPTH+1)
67 67
   uint8_t file_subcall_ctr;
68 68
   uint32_t filespos[SD_PROCEDURE_DEPTH];
69 69
   char filenames[SD_PROCEDURE_DEPTH][MAXPATHNAMELENGTH];

Loading…
Cancel
Save