Browse Source

For now (!) don't synchronize in M204 and M205

See if this has any deleterious effect on motion planning by slicers that inser their own jerk and acceleration controls. The problem I see is that these settings can take effect on blocks already in the planner, and the only way around this would be to shadow these settings in planner blocks and use the shadowed settings in the planner.
Scott Lahteine 5 years ago
parent
commit
da17f8ad37
1 changed files with 2 additions and 2 deletions
  1. 2
    2
      Marlin/src/gcode/config/M200-M205.cpp

+ 2
- 2
Marlin/src/gcode/config/M200-M205.cpp View File

@@ -97,7 +97,7 @@ void GcodeSuite::M204() {
97 97
     SERIAL_ECHOLNPAIR(" T", planner.settings.travel_acceleration);
98 98
   }
99 99
   else {
100
-    planner.synchronize();
100
+    //planner.synchronize();
101 101
     // 'S' for legacy compatibility. Should NOT BE USED for new development
102 102
     if (parser.seenval('S')) planner.settings.travel_acceleration = planner.settings.acceleration = parser.value_linear_units();
103 103
     if (parser.seenval('P')) planner.settings.acceleration = parser.value_linear_units();
@@ -131,7 +131,7 @@ void GcodeSuite::M205() {
131 131
   #endif
132 132
   if (!parser.seen("BST" J_PARAM XYZE_PARAM)) return;
133 133
 
134
-  planner.synchronize();
134
+  //planner.synchronize();
135 135
   if (parser.seen('B')) planner.settings.min_segment_time_us = parser.value_ulong();
136 136
   if (parser.seen('S')) planner.settings.min_feedrate_mm_s = parser.value_linear_units();
137 137
   if (parser.seen('T')) planner.settings.min_travel_feedrate_mm_s = parser.value_linear_units();

Loading…
Cancel
Save