Browse Source

Better STM32 Tone timer int priority (#18385)

Jason Smith 4 years ago
parent
commit
e52afa8b19
No account linked to committer's email address
2 changed files with 10 additions and 0 deletions
  1. 9
    0
      Marlin/src/HAL/STM32/timers.cpp
  2. 1
    0
      platformio.ini

+ 9
- 0
Marlin/src/HAL/STM32/timers.cpp View File

@@ -36,6 +36,15 @@
36 36
   #define TEMP_TIMER_IRQ_PRIO 14   // 14 = after hardware ISRs
37 37
 #endif
38 38
 
39
+// Ensure the default timer priority is somewhere between the STEP and TEMP priorities.
40
+// The STM32 framework defaults to interrupt 14 for all timers. This should be increased so that
41
+// timing-sensitive operations such as speaker output are note impacted by the long-running
42
+// temperature ISR. This must be defined in the platformio.ini file or the board's variant.h,
43
+// so that it will be consumed by framework code.
44
+#if !(TIM_IRQ_PRIO > STEP_TIMER_IRQ_PRIO && TIM_IRQ_PRIO < TEMP_TIMER_IRQ_PRIO)
45
+  #error "Default timer interrupt priority is unspecified or set to a value which may degrade performance."
46
+#endif
47
+
39 48
 #if HAS_TMC_SW_SERIAL
40 49
   #include <SoftwareSerial.h>
41 50
   #ifndef SWSERIAL_TIMER_IRQ_PRIO

+ 1
- 0
platformio.ini View File

@@ -329,6 +329,7 @@ build_flags   = ${common.build_flags}
329 329
   -IMarlin/src/HAL/STM32 -std=gnu++14
330 330
   -DUSBCON -DUSBD_USE_CDC
331 331
   -DUSBD_VID=0x0483
332
+  -DTIM_IRQ_PRIO=13
332 333
 build_unflags = -std=gnu++11
333 334
 src_filter    = ${common.default_src_filter} +<src/HAL/STM32>
334 335
 

Loading…
Cancel
Save