Parcourir la source

ZNC: don't make install if configure or make fail

ZNC module compilation can fail on memory-limited systems, causing ZNC
to not work properly. But even after the failure, make install still
creates /usr/local/bin/znc. Thus Ansible would skip the ZNC build and
install step on future runs, despite ZNC not being correctly installed,
causing the playbook to appear to complete successfully and requiring
manual troubleshooting.
catern il y a 10 ans
Parent
révision
54e62152d2
1 fichiers modifiés avec 1 ajouts et 1 suppressions
  1. 1
    1
      roles/ircbouncer/tasks/znc.yml

+ 1
- 1
roles/ircbouncer/tasks/znc.yml Voir le fichier

@@ -23,7 +23,7 @@
23 23
   command: tar xzf /root/znc-{{ znc_version }}.tar.gz chdir=/root creates=/root/znc-{{ znc_version }}/configure
24 24
 
25 25
 - name: Build and install znc
26
-  shell: ./configure --enable-python ; make ; make install executable=/bin/bash chdir=/root/znc-{{ znc_version }} creates=/usr/local/bin/znc
26
+  shell: ./configure --enable-python && make && make install executable=/bin/bash chdir=/root/znc-{{ znc_version }} creates=/usr/local/bin/znc
27 27
   notify: restart znc
28 28
 
29 29
 - name: Create znc group

Chargement…
Annuler
Enregistrer